Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for agents integrations docs #1498

Merged
merged 32 commits into from
Feb 23, 2024
Merged

Conversation

neverett
Copy link
Contributor

@neverett neverett commented Feb 14, 2024

Updates integrations docs for Flyte agents GA.

Related: flyteorg/flyte#4822

In this PR

Note: Links to the new agents integrations guide and the Airflow and Snowflake deployment configuration pages are broken because those docs are in a flyte branch (see flyteorg/flyte#4822).

@neverett neverett requested a review from ppiegaze as a code owner February 14, 2024 23:28
@neverett neverett self-assigned this Feb 14, 2024
nikki everett added 12 commits February 15, 2024 13:58
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
nikki everett added 11 commits February 16, 2024 17:05
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
@neverett neverett changed the title Updates for agents (integrations docs) Updates for agents integrations docs Feb 20, 2024
nikki everett added 4 commits February 21, 2024 11:09
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
ppiegaze
ppiegaze previously approved these changes Feb 22, 2024
Signed-off-by: nikki everett <[email protected]>
@EngHabu
Copy link
Contributor

EngHabu commented Feb 22, 2024

@eapolinario can you help taking a look at the build error on Monodocs?

@neverett
Copy link
Contributor Author

neverett commented Feb 22, 2024

@EngHabu @eapolinario the monodocs build will fail until flyteorg/flyte#4822 is merged, since this is one of those situations with cross-repo docs dependencies. The flyte PR shouldn't be merged until this one is ready to merge, though, since that PR links to docs in this PR. (Basically, the two PRs need to be merged as close to simultaneously as possible.)

The build failure I've been unable to resolve is the MNIST classifier example failure. I tried updating the ephemeral storage param in the example code, since I was seeing errors about storage space being exceeded, and also tried bumping the flytekit version in the requirements.txt per Samhita's recommendation, but I can't get that example to build. (To be clear, the MNIST example is not related to agents in any way, it just started failing recently for mysterious reasons.)

@neverett
Copy link
Contributor Author

neverett commented Feb 22, 2024

I went ahead and reset the MNIST classifier example ImageSpec and requirements back to what they look like in master so engineers can more easily debug.

Thinking about this a bit more, I think we should go ahead and merge this PR without fixing the MNIST classifier example, as long as the agents content looks good. The fact that the MNIST classifier example is failing in this PR means it's already broken in production; we should fix it separately rather than block this PR to fix it.

@ppiegaze ppiegaze self-requested a review February 23, 2024 15:09
ppiegaze
ppiegaze previously approved these changes Feb 23, 2024
Signed-off-by: nikki everett <[email protected]>
@neverett neverett merged commit af6f253 into master Feb 23, 2024
77 of 94 checks passed
@neverett neverett deleted the docs/agents-docs-updates branch February 23, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants